Translated fertilizer name for "ran out of fertilizer" message #38261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BevapDin
reviewed
Feb 23, 2020
Co-Authored-By: BevapDin <tho_ki@gmx.de>
ZhilkinSerg
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Translated fertilizer name for ran-out-of-fertilizer message"Purpose of change
Fixes #38255 to show the name of the fertilizer that ran out, instead of the item key.
Describe the solution
Added code to get the tname() of the item instead of using the item key.
After fix:
Describe alternatives you've considered
I wasn't sure about the "right way" to get a tname from an item ID, so there are probably other ways to do this in code.
Testing
Fertilized with small amounts of fertilizer before and after the fix.
Additional context
If there is a better way to get to a translated name from an item ID, please let me know.